Skip to content

intel: Introduce NVL and NVL-S platforms#10156

Merged
lgirdwood merged 2 commits intothesofproject:mainfrom
serhiy-katsyuba-intel:nvl_upstream
Aug 27, 2025
Merged

intel: Introduce NVL and NVL-S platforms#10156
lgirdwood merged 2 commits intothesofproject:mainfrom
serhiy-katsyuba-intel:nvl_upstream

Conversation

@serhiy-katsyuba-intel
Copy link
Contributor

@serhiy-katsyuba-intel serhiy-katsyuba-intel commented Aug 7, 2025 •
edited
Loading

Initial commits to introduce NVL and NVL-S platforms.

  NVL-S  vs  NVL:
      2  vs  4 cores,
438.857  vs  614.4 MHz,
   2048  vs  4608 KB L2 HP SRAM.

lgirdwood
lgirdwood reviewed Aug 7, 2025
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ping when Zephyr parts are merged and we can merge this.

@lgirdwood lgirdwood added the DNM Do Not Merge tag label Aug 7, 2025
@serhiy-katsyuba-intel
Copy link
Contributor Author

serhiy-katsyuba-intel commented Aug 11, 2025

Zephyr PR zephyrproject-rtos/zephyr#94207 is now merged. west.yml commit is updated.

@serhiy-katsyuba-intel serhiy-katsyuba-intel marked this pull request as ready for review August 11, 2025 14:49
lgirdwood
lgirdwood approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw we should be able to remove some of teh platform headers soon once Zephyr clock driver and IPC infra get merged.

lyakh
lyakh reviewed Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of places with apparently wrong indentation

@serhiy-katsyuba-intel
Copy link
Contributor Author

serhiy-katsyuba-intel commented Aug 12, 2025

LGTM, ping when Zephyr parts are merged and we can merge this.

@lgirdwood , DNM label can now be removed?

@lgirdwood
Copy link
Member

lgirdwood commented Aug 12, 2025 •
edited
Loading

CI fuzzer error unrelated to new platform and logged here #10160

EDIT: forgot about the west update, this could be related to Zephyr update since fuzzer showing thread APIs in the logs.

@serhiy-katsyuba-intel could you do a stand alone PR with just the west update to see if we still get the fuzzer failure. This will confirm Zephyr issue. Thanks !

@serhiy-katsyuba-intel
Copy link
Contributor Author

serhiy-katsyuba-intel commented Aug 12, 2025

@serhiy-katsyuba-intel could you do a stand alone PR with just the west update to see if we still get the fuzzer failure. This will confirm Zephyr issue. Thanks !

Draft PR with just Zephyr update: #10161

@lgirdwood
Copy link
Member

lgirdwood commented Aug 12, 2025

CI fuzzer error unrelated to new platform and logged here #10160

@serhiy-katsyuba-intel could you do a stand alone PR with just the west update to see if we still get the fuzzer failure. This will confirm Zephyr issue. Thanks !

Draft PR with just Zephyr update: #10161

Thanks - #10161 fuzzer fails so looks like we are blocked on Zephyr fix.

@abonislawski
Copy link
Member

abonislawski commented Aug 21, 2025

Please disable winstream logs like for PTL:
#10180

@serhiy-katsyuba-intel
Copy link
Contributor Author

serhiy-katsyuba-intel commented Aug 21, 2025

Please disable winstream logs like for PTL: #10180

Done.

@serhiy-katsyuba-intel
intel: nvl: add NVL platform
f7974b4 
Initial commit to add Nova Lake platform.

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@serhiy-katsyuba-intel
intel: nvl-s: Add Nova Lake -S variant
1c2ddaf 
Adds Nova Lake -S (aka NVL-S, Nova Lake PCH-S, NVPS) variant of Nova Lake
ACE 4.x SoC.

  NVL-S  vs  NVL:
      2  vs  4 cores,
438.857  vs  614.4 MHz,
   2048  vs  4608 KB L2 HP SRAM.

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
tmleman
tmleman reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

@tmleman tmleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zephyr was updated in #10124
Please do a rebase.

@serhiy-katsyuba-intel
Copy link
Contributor Author

serhiy-katsyuba-intel commented Aug 26, 2025

Zephyr was updated in #10124 Please do a rebase.

Removed west.yml update commit.

@lgirdwood
Copy link
Member

lgirdwood commented Aug 26, 2025

cmocka EQ mock exception is known and unrelated. @singalsu fyi.

@lgirdwood
Copy link
Member

lgirdwood commented Aug 26, 2025

@serhiy-katsyuba-intel looks like we are missing the compiler from Zephyr SDK

CMake Error at /zep_workspace/zephyr/cmake/compiler/gcc/target.cmake:11 (message):
  C compiler
  /opt/toolchains/zephyr-sdk-0.17.0/xtensa-intel_ace40_zephyr-elf/bin/xtensa-intel_ace40_zephyr-elf-gcc
  not found - Please check your toolchain installation
Call Stack (most recent call first):
  /zep_workspace/zephyr/cmake/modules/FindTargetTools.cmake:103 (include)
  /zep_workspace/zephyr/cmake/modules/kernel.cmake:25 (find_package)
  /zep_workspace/zephyr/cmake/modules/zephyr_default.cmake:140 (include)
  /zep_workspace/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  /zep_workspace/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
  CMakeLists.txt:5 (find_package)

@cgturner1 who can add NVL compiler to ZephyrSDK ?

@lgirdwood lgirdwood merged commit 74651bb into thesofproject:main Aug 27, 2025
36 of 47 checks passed
@lgirdwood
Copy link
Member

lgirdwood commented Aug 27, 2025

merging now, as it may take some time for SDK update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakh lyakh lyakh left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@abonislawski abonislawski abonislawski approved these changes

@kv2019i kv2019i kv2019i approved these changes

@marcinszkudlinski marcinszkudlinski marcinszkudlinski approved these changes

@tmleman tmleman tmleman approved these changes

@softwarecki softwarecki softwarecki approved these changes

@akloniex akloniex Awaiting requested review from akloniex akloniex is a code owner

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan iuliana-prodan is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@tlissows tlissows Awaiting requested review from tlissows tlissows is a code owner

@singalsu singalsu Awaiting requested review from singalsu singalsu is a code owner

@RanderWang RanderWang Awaiting requested review from RanderWang RanderWang is a code owner

@pblaszko pblaszko Awaiting requested review from pblaszko pblaszko is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

Assignees

No one assigned

Labels

DNM Do Not Merge tag

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@serhiy-katsyuba-intel @lgirdwood @abonislawski @lyakh @kv2019i @marcinszkudlinski @tmleman @softwarecki